http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663
Galen Charlton <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Galen Charlton <[email protected]> --- I have pushed all that I intend to push for this bug, to master. I've included a follow-up to set issuingrules explicitly for the purposes of Circulation.t. Some observations: - While fixing the regression is extremely important, of course, the most important part of the patch series from the POV of Koha's maintainability are the new test cases. My thanks to Tomás and Katrin for writing them. My particular thanks to Katrin for taking this opportunity to start learning how to write DB-dependent tests. - This incident further strengthens my disinclination to push patches that aim to refactor or "clean up" code that are not accompanied by test cases that completely (as humanly possible) exercise the visible behavior whose implementation is being reworked. - I acknowledge that the DB-dependent test suites currently make assumptions about which sample data is in place that are unwarranted. I also know that many people, myself included, have been chipping away at those issues. - Obviously there /is/ quite a bit of infelicity in the C4::Reserves API -- and it needs to be improved. Yea, I say unto you, it even needs to be refactored. :) But that's not going to happen without test cases. As a starting point, I suggest that those who are interested go through C4/Reserves.pm, identify problematic routines, file bugs for each, and write test cases demonstrating what the expected behavior is. - I am not opposed to squashing patches, particularly in cases where there's been flip-flopping or if judicious squashing would significantly improve the readability of the patch series. I am /strenuously/ opposed to squashes that remove author attribution, even inadvertently. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
