http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556
Galen Charlton <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton <[email protected]> --- Thanks, Jonathan! I've pushed the part of the patch that changed AddBookSeller to master, along with a follow-up that adds a regression test. However, I have not pushed the part that updates ModBookSeller on the following grounds: [1] That routine is not actually related to the bug. [2] The proposed change to that routine is purely cosmetic. Cosmetic and source reformatting patches really ought to be separate from ones that change functionality or fix bugs. [3] The proposed reformatting has issues -- in particular, I simply do not see the point of the changes proposed to lines 240-254. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
