https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40313

--- Comment #7 from David Cook <[email protected]> ---
(In reply to Marcel de Rooy from comment #6)
> git grep
> koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:          
> update_category_code( "[% borrower_data.categorycode | html %]" );
> koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:          
> update_category_code( category_code );
> koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:          
> update_category_code(this);
> koha-tmpl/intranet-tmpl/prog/js/members.js:function
> update_category_code(category_code) {
> 
> Shouldnt we change this part in the template:
> 
>             $("#categorycode_entry").on("change", function(){
>                 update_category_code(this);
>             });
> And have a consistent param type in the function?

I think that would be the optimal outcome for sure.

I was short on time locally, so this was the shortest path to a working
version, and I figured I'd upstream that. 

But yes I think a better overall solution would be to change the rest of the
template/javascript to be more consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to