https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40118
--- Comment #6 from Jonathan Druart <[email protected]> --- (In reply to Pedro Amorim from comment #4) > (In reply to Jonathan Druart from comment #3) > > - let value = this.value.length ? "^" + this.value + "$" > > : ""; > > > > Can you explain this? > > > > Now we should have tests for changes to this file (See bug 40002 that > > introduced this change). > > It's unused code. The 'value' variable is never used. It's caused by 3fce8f83dc9696936342c6c3289389cc0eb38c2b - table_dt - .column(i) - .search( this.value.length ? '^'+this.value+'$' : '', true, false ) - .draw(); + $(this).find("select") + .unbind() + .bind("keyup change", function(){ + let value = this.value.length ? '^'+this.value+'$' : ''; + col_select_search(i, this.value) + }); Should be `col_select_search(i, value)` then I assume. But now the values have the ^$ in them. I am then wondering what's better... Maybe we need to deal with that on a separate bug. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
