http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215
--- Comment #9 from Galen Charlton <[email protected]> --- Comment on attachment 19335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19335 Bug 10215 - Increase the size of opacnote and librariannote for table subscriptionhistory Review of attachment 19335: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10215&attachment=19335) ----------------------------------------------------------------- ::: C4/Serials.pm @@ +483,4 @@ > $subs->{startdate} = format_date( $subs->{startdate} ); > $subs->{histstartdate} = format_date( $subs->{histstartdate} ); > $subs->{histenddate} = format_date( $subs->{histenddate} ); > + $subs->{opacnote} ||= q{}; Consider what happens if the opacnote happens to "0". The note entered by the user would not be displayed. Since 5.10 is the minimum version of Perl required by Koha, we can freely using the //= operator, and I recommend that you do that when you want to conditionally convert an undefined value to the empty string. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
