https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39876
--- Comment #9 from Jonathan Druart <[email protected]> --- (In reply to David Nind from comment #5) > Apologies in advance for the long comment! > > Everything looks OK before the patches. > > After the patches, several tests fail: > > prove xt/author/codespell.t - before = 4440 PASS; after = 4616 FAIL It was missing the exclusion list. after 4439 > prove xt/perltidy.t - before = 3018 PASS; after = 3296 FAIL It was missing the exclusion list. > prove xt/pl_valid.t - before = 3298 PASS; after = 1 FAIL Fixed now. In the test plan I stated that there should be more files tested after than before. It's actually true, but the number of tests does not exactly represent the number of files tested, because of duplication. Here is the diff of the list of files: 350a351 > Koha/Devel/Files.pm 2341d2341 < opac/svc/shelfbrowser.pl 2440d2439 < svc/cataloguing/automatic_linker.pl Those 2 svc files are actually duplicated in the "main" version and are tested twice. > prove xt/tt_tidy.t - before = 866 PASS; after = 3017 FAIL Oops, it was retrieving the perl files :-/ It's fixed now. There is this difference in the files tested: 86d85 < koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-open.inc 714d712 < koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-open.inc 854,858d851 < misc/cronjobs/rss/lastAcquired-1.0.tt < misc/cronjobs/rss/lastAcquired-2.0.tt < misc/cronjobs/rss/lastAcquired.tt < misc/cronjobs/rss/longestUnseen.tt < misc/cronjobs/rss/mostReserved.tt This is because we are fixing an inconsistency: misc/devel/tidy.pl was excluding them, but xt/tt_tidy.t was not (but the files was skipped later anyway). Now they are excluded for both. > After the patches, and a misc/devel/tidy.pl --perl, there is a file change > when you do a git status: Oops, fixed now. > Maybe there is something else I need to do after applying the patches? > (Other than a restart_all.) Nope, it's just me submitting patches too late in the evening, and being lazy to run again the whole test suite. Sorry about that and thanks a lot for your testing! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
