http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] | |m Assignee|[email protected] |[email protected] |ity.org | --- Comment #15 from Jonathan Druart <[email protected]> --- QA comment: There is a design issue in this patch: First, you add a column in a sql table only for some rows (in this case for categorycode=Bsort1). Then, multiple values are added into this column (you lost the foreign key to the patron categories). I don't like to say that but maybe a syspref is much more appropriate here. Ergonomic issue: A new column is added in the authorised values table, but the header only exists for the Bsort1 category. So there is a shift in others categories. Looking at the code: 1/ You use an unused tt variable (looploop). 2/ - SELECT id, category, authorised_value, lib, lib_opac, imageurl + SELECT * It is preferable to enumerate fields. Marked as Failed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
