https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600
--- Comment #21 from Pedro Amorim <pedro.amo...@openfifth.co.uk> ---
Putting this as "Signed-off". Thank you Tadeusz.
I had to reorder the patches to have them apply nicely (please always submit
the whole patchset when re-submiting a patch other than the last one, or
they'll fall out of order).
The QA script is complaining about the following:
FAIL Koha/ILL/Request.pm
FAIL tidiness
File is not tidy, please run `perl misc/devel/tidy.pl
Koha/ILL/Request.pm`
FAIL Koha/ILL/Request/Attribute.pm
FAIL pod coverage
POD is missing for 'public_read_list'
FAIL Koha/REST/V1/ILL/Requests.pm
FAIL pod coverage
POD is missing for 'patron_list'
FAIL tidiness
File is not tidy, please run `perl misc/devel/tidy.pl
Koha/REST/V1/ILL/Requests.pm`
OK api/v1/swagger/paths/patrons.yaml
OK api/v1/swagger/swagger.yaml
OK koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
FAIL filters
missing_filter at line 413 ( "url":
'/api/v1/patrons/[% logged_in_user.borrowernumber %]/ill/requests',)
FAIL tidiness
File is not tidy, please run `perl misc/devel/tidy.pl
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt`
FAIL opac/opac-illrequests.pl
FAIL tidiness
File is not tidy, please run `perl misc/devel/tidy.pl
opac/opac-illrequests.pl`
FAIL t/db_dependent/api/v1/ill_requests.t
FAIL tidiness
File is not tidy, please run `perl misc/devel/tidy.pl
t/db_dependent/api/v1/ill_requests.t`
Processing additional checks OK!
Running tests (1)
* Proving /kohadevbox/koha/t/db_dependent/api/v1/ill_requests.t OK!
---------------
To have the code automatically tidied for you on commit, consider using the pre
commit hook:
https://gitlab.com/koha-community/koha-testing-docker/-/blob/main/files/git_hooks/pre-commit
This comes built-in with k-t-d.
These should be easy fixes, once we have these fixed I think we should be able
to move this to "Passed QA".
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
