https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600
Pedro Amorim <pedro.amo...@openfifth.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #15 from Pedro Amorim <pedro.amo...@openfifth.co.uk> ---
This is great work and greatly appreciated.
I'm failing QA, to encourage quick follow-up, for the following reasons:
1) The new endpoint method patron_list needs a test in
t/db_dependent/api/v1/ill_requests.t e.g. proving that requests cannot be
retrieved for a different patron.
2) This needs a proper test plan (possibly on the main patch's commit message)
e.g.:
- Enable ILLModule
- Create 50 requests for koha patron, run (if k-t-d):
perl -Mt::lib::TestBuilder -e '
my $builder = t::lib::TestBuilder->new;
do {
$builder->build_sample_ill_request({borrowernumber => 51});
} for (1..50);
'
- Access the OPAC ILL requests page:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl
- Notice the requests are shown, paginated.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
