https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010
--- Comment #276 from Jonathan Druart <[email protected]> --- Testing on top of: c0fc58efa3b (openfifth/bug_38010) Bug 38010: (QA follow-up) Fix toolbar on VendorShow 1. Should we provide more rewrite rule to not break existing bookmarks? For instance http://localhost:8081/cgi-bin/koha/acqui/supplier.pl?booksellerid=1 now returns 404 2. Why do we have /cgi-bin/koha/vendors instead of /cgi-bin/koha/acquisition/vendors ? 3. breadcrumb: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor Click "Vendors" in the breadcrumb: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor# Expected: see all vendors Not a regression, and not sure we can fix here. 4. Filtering: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor "Showing 1 to 1 of 1 entries (filtered from 3 total entries)" But you have no way to remove the filtering and see all vendors It is the current behaviour in main, but at least we had "Search for vendor my vendor" in the breadcrumb 5. http://localhost:8081/cgi-bin/koha/acqui/vendors.pl interestingly shows: https://snipboard.io/5Pmeq2.jpg 6. http://localhost:8081/cgi-bin/koha/vendors/2 Warning in the console: [Vue Router warn]: Discarded invalid param(s) "vendor_id" when navigating. 7. http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=2 Errors in the console: Uncaught (in promise) DOMException: CustomElementRegistry.define: 'vendor-menu' has already been defined as a custom element Uncaught (in promise) DOMException: CustomElementRegistry.define: 'acquisitions-menu' has already been defined as a custom element 8. show vendor view: a. website is a button: https://snipboard.io/16ZLPA.jpg (same for the interfaces) b. contact options does not display correctly: https://snipboard.io/UI8Ko6.jpg c. "New" menu: the entries does not have the dropdown-item class => incorrect styling on mouse over: https://snipboard.io/aiB8zw.jpg c. Entries in the "New" menu open in new tab (same for "Receive shipments") 9. edit vendor: a. hit enter when you add an alias: the form is submitted. This is a regression, we prevented that in the current code with: acqui/supplier.tt:596 nodes.append("<input id='new_alias' type='text' class='noEnterSubmit' />"); b. enter "foo" in discount: cannot save, no error on the UI, 400 in the response: {"errors":[{"message":"Expected number\/null - got string.","path":"\/body\/discount"}],"status":400} c. enter 111 in the discount, cannot save, no error on the UI, 500 in the response. Koha log has: Out of range value for column 'discount' d. delete an interface not working: "Uncaught TypeError: _ctx.deleteContact is not a function" 10. cannot edit from the list view: Uncaught Error: Missing required param "id" -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
