http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy <[email protected]> --- QA Comment: Code (on itself) looks good to me. No qa-tools complaints. Also the need for a job to optionally delete acquisition records is recognized. I only wonder if you should only delete from aqorders and if receiveddate should be the date to trigger the action. The following thoughts are not blocking this patch, but just raise a discussion about it: Why not delete baskets? Now we can be stuck with empty baskets. Would you really want to delete orders from an open basket or a basket that has not been received fully? Personally, I would go for a job that deletes inactive baskets (closed and all received) with creationdate as trigger. E.g. I could annually delete all inactive baskets, created more than one year ago or something. In the hope that these considerations may stimulate further improvements and since it only is one new script, passing qa. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
