https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36822
--- Comment #32 from Pedro Amorim <[email protected]> --- (In reply to Aleisha Amohia from comment #24) > Really keen to pass QA on this but a few QA tool warnings to address first > please: Thank you Aleisha, I've squashed perltidy tidyness to the tests files patches to address the warnings of Auth_with_ldap.t and Auth_with_shibboleth.t I've also submitted a follow-up to prevent tests from failing if enough time has gone by between user being created and the test running (stumbled upon this while revisiting). I've spent an unreasonable amount of time trying fix the tidy warning of 1 untidy line in C4/Auth.pm and I can't fix it barring tidying the whole file. I'm happy to have someone else fix this tidy warning for me on C4/Auth.pm but I also don't think this should be reason enough to block these patches. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
