https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260
--- Comment #147 from Martin Renvoize (ashimema) <[email protected]> --- Thanks for the replies everyone. I'm sold in the marking as sent, that makes sense, especially when a notice is coming from 'pending' and is a 'print' type notice in the first place. The query comes from those notices that appear in these two pages that are already in another state and especially those that are not 'print' type. Makeing them sent when they were pending will prevent emails from going out for example.. though I suppose it does make sense if they're in a failure state and you want to use print as a fallback. Anyway, I'm happy to accept 'sent' for all. I do have another couple of questions however. In the bulk select and print process, each notice is printed without any additional spacing between, all on one page one after the other. Should we not add page breaks between notices so you have a notice per page (gather_print_notices appears to have lost this page breaking functionality somewhere along the line :( ) Do we also need to consider including headers here with address details etc. For print type notices we usually include physical address details right in the notice, but when printing an email type notice you currently won't get any addressee detail.. for a bulk print this would get confusing quickly I think. (This could be done in a follow-up bug perhaps.. or we could limit to print type notices for the print functionality at first?) The thing I'm finding hard to fully understand here is the mix of notice transport types all in this one print option. If the transport type was 'print' it makes a fair bit of sense because you usually have address details as part of the notice itself.. if it was an email then you won't get any addressee details at all in most notices with this print option. I can see it being nice to individually print a copy of an email notice upon request or when email has failed. Again, adding this header support could perhaps be a follow-up bug a this stage. Finally, I've been trying to dry out our printing code, but this itbeoduces yet another printslip controller that's almost a copy paste of the 6+ existing scripts.. why not use members/printnotice.pl which I was trying to keep as a simple single place for printing slips so we stop adding new functionality and then forgetting to replicated I. The 6+ clones of code? I'll look at doing that here to save me the job of later removing that scriot again. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
