https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355
Nick Clemens (kidclamp) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #63 from Nick Clemens (kidclamp) <[email protected]> --- Doubled pref in patches: pref: SerialsDefaultReplyTo looks like rebase issues A user can CRUD Marc Order Accounts with only catalogue permissions - I think it needs to be a new subpermission of acquisitions A full search of vendors is used on the marc order accounts page - this should be a select2 and not load all into template (we have partners with thousands of vendors) create_items is not set for basket - I think 'ordering' is required? maybe this setting is just ignored for this process? you mention _stage_file is a clone from the background job. it should be moved into a place that can be shared with the background job to dry the code match_file_to_account - POD should indicate only the first record is checked on the account page it should specify the format, dollar sign for subfields, i.e. 245$a Commit titles below don't match the patches, can you explain? Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings and introduce MarcFieldsToOrder to cronjob Bug 34355: Add a plugin hook - before_orderline_create koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_order_accounts.tt The selected option choices are split by the conditionals, include the full option selected or not You remove the use of tools-overlay-action.inc / tools-nomatch-action / tools-item-action - I think we should keep this to not repeat - the selection variables lok unsused so can be updated to work with the data here (e.g. git grep overlay_action_replace ) Warning when processing test file: Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 5. Maybe a data problem with the file? The cronjob deletes the file - I think we want an option to rename/move the file, rather than full deletion - if something is wrong, we want the file for reference It looks like a few fields were not included in _create_item_fields_from_syspref: coded_location_qualifier, barcode, and enumchron - special field quantity -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
