https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36217
David Cook <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from David Cook <[email protected]> --- Great job here, Johanna. Thanks so much for writing this patch! It is failing the QA tools at the moment for tidiness[1] With the test plan, there are some missing steps. After applying the patch, the tester needs to run "perl build-resources.PL" to update the swagger_bundle.json. At least in koha-testing-docker. That's a fairly new thing though. Not a big issue there, but worth noting. The test plan (and the unit test) should also include some steps for verifying that the "Current jobs only" filter works in combination with the "Only include jobs enqueued in the last hour". I manually tested it, and it works (yay!), but good to have an automated test for it too. That shouldn't take you long. So marking this as Failed QA, but I think you'll have it fixed up quickly. If you're struggling with any of the above, let me know any I'll give you a hand. Thanks! -- [1] testing 1 commit(s) (applied to 5c8baaf '61 Bug 37302: (follow-up) Update yarn') Processing files before patches |========================>| 5 / 5 (100.00%) Processing files after patches |========================>| 5 / 5 (100.00%) WARN Koha/BackgroundJobs.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 9, now: 14) WARN Koha/REST/V1/BackgroundJobs.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 7, now: 8) OK api/v1/swagger/paths/jobs.yaml OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt WARN t/db_dependent/Koha/BackgroundJobs.t WARN tidiness The file is less tidy than before (bad/messy lines before: 19, now: 21) Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - 6b17c7d888 Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Koha/BackgroundJobs.t OK! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
