https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37213

--- Comment #6 from Owen Leonard <[email protected]> ---
(In reply to Marcel de Rooy from comment #4)
> This looks a bit odd. I would not expect created or deleted to pop up in the
> breadcrumbs. If something failed, we should have a dialog alert somewhere
> else.

We do have a dialog alert. The thing which is inconsistent about this page is
that there is a "creation success/failure" stage at all. Usually we would
redirect to the list of collections in either case, adding a dialog if there
was an error. 

I think these changes are logical given the unusual workflow of having a
"success" page.


> The quoted empty string comes from there. Should the script pass a correct
> op and record id here instead? If you delete a collection, probably the op
> should change to new. If you added or updated, we need the record id.
> 
> Note also that I see an </em> without an opening <em> ?

These issues are all unrelated to the changes in the original patc. I've
submitted a follow-up to correct them.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to