http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218

Bernardo Gonzalez Kriegel <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #19 from Bernardo Gonzalez Kriegel <[email protected]> ---
Hi,
it works with search, but...

1) --batch option continues to ask confirmation

2) koha-qa complains. You are using Modern::Perl,
so you must change the way to open a file
change this
 open( FILE, "$biblios" ) || die("Can't open $biblios");
to this
 open my $FILE,"<","$biblios" or die("Can't open $biblios");
and the closing/reading accordingly.

3) You are checking for a filename assuming a '/' in filename (absolute)
if ( $biblios =~ m|/| )
change to 
if ( -e $filename )
to allow any file name,
then, if not exists, check if the resulting string is composed by numbers.

4) You are reading the file with
@bibliofile = <FILE>;
that reads 1 line only

5) --where filename do not work
I put 3 biblionumber on a file, run command and the result 
was weird, prints that was about to check 100 bibs, and enter
endless loop

Not ready yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to