http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Katrin Fischer <[email protected]> --- Hi Matthias, I finally got to look at this, but I spotted some problems with the patch. I think they might stem from this development being based on an older version of Koha. The major things I found are: 1) You are using SELECT SQL_CALC_FOUND_ROWS which is a MySQLism. Please can you rewrite that part? 2) I think you remove an existing feature as I can't see where this is added back in: - <li><label for="pagesize">Show: </label> - <input type="text" id="pagesize" name="pagesize" value="[% pagesize %]" maxlength="5" size="5" /> items</li> - <li><label for="offset">Beginning at offset: </label> - <input type="text" id="offset" name="offset" value="[% offset %]" size="5" maxlength="5" /> - </li> 3) There are changes related to authentication that don't seem to belong into this patch? 4) The calendar related code seems to be based on older code, using C4:Dates and i spotted one DHTML... - could you take a look? 5) There are some problems with the templates, like capitalization, terms used and the id in the body going missing. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
