http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #17 from mathieu saby <[email protected]> --- Hello Lyon 3 I made the following test to check the way Koha was handling multi-currency prices. I defined these currencies : EUR € 1.00 (active) USD $ 0.50 Before applying your patch, I created a basket with staged records, selecting EUR currency in Accounting details (in addorderiso2709.pl). I applied the patch, and created an other basket with the same file of stage records. Here are the results. It is not good before your patch, not good after, but in a different way :( So managing multi-currency prices is a complex issue. I suggest you to rewrite your patch only to fix the initial bug (, instead of . in prices), so that we could push your fix as soon as possible. And create an other ticket for improving/fixing multi-currency prices support... What do you think of that? Detailed test : Record 1 : 010$d : 75.00 €, 30.00 $ Without your patch => in basket : 30 euros With your patch => in basket : 75 euros Record 2 : 010$d : 25.00€, 32.00$ Without your patch => in basket : 32 euros With your patch => in basket : 25 euros Record 3 : 010$d : €22.00, $56.00 Without your patch => in basket : 22 euros With your patch => in basket : 22 euros Record 4 : 010$d : $42.00, £12.00 Without your patch => in basket : 0 (uncertain price) With your patch => in basket : 0 (uncertain price) Record 5 : 010$d : 20.40 EUR, 12.50 USD Without your patch => in basket : 20.40 euros With your patch => in basket : 20.40 euros Record 6 : 010$d : 112.10 €, 110.15 $, 90.15 £ Without your patch => in basket : 110.15 euros With your patch => in basket : 112.10 euros Record 7 : 010$d : 1125.00 EUR Without your patch => in basket : 1125 euros With your patch => in basket : 1125 euros Record 8 : 010$d : €125.00 Without your patch => in basket : 125 euros With your patch => in basket : 125 euros Record 9 : 010$d : 1125.50 USD Without your patch => in basket : 1125.50 euros With your patch => in basket : 1125.50 euros Record 10 : 010$d : $1125.50 Without your patch => in basket : 0 (uncertain price) With your patch => in basket : 0 (uncertain price) Record 11 : 010$d : $10.00, €12.00 Without your patch => in basket : 0 (uncertain price) With your patch => in basket : 0 (uncertain price) Record 12 : 010$d : 10.00 $, 12.00 € Without your patch => in basket : 10 euros With your patch => in basket : 10 euros Record 13 : 010$d : 10.00 USD, 12.00 EUR Without your patch => in basket : 10 euros With your patch => in basket : 10 euros Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
