https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA Keywords| |rel_24_05_candidate --- Comment #23 from Katrin Fischer <[email protected]> --- I really want this for 24.05, please help me make it happen: 1) Failing unit test (blocker) It looks like you forgot to adjust the t/db_dependent/Koha_Elasticsearch.t to the new name of the method. I tried to fix it, but even after changing the method names the test still keeps failing. I think some more is needed. Please provide a follow-up ASAP. 2) Labels cannot be edited (blocker) The test plan states: "Librarians can then add/remove facet fields and modify their label." But I haven't been able to update the label for my own custom facets. The field remains "locked" and doesn't ever appear as an input field. Tiny things I had fixed on my branch: 3) The database update is missing a success message. I had used: + say $out "Updated DisplayLibraryFacets and search field configuration"; 4) Tiny typo: exist -> exists - alert(__("SearchField '%s' already exist".format(search_field_name))); + alert(__("SearchField '%s' already exists".format(search_field_name))); For a separate bug maybe: ?) Show delete button only after saving? At the moment the delete button shows for a newly added field, but it doesn't work. I think it would make sense to hide it, until the page has been saved. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
