https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|[email protected] |[email protected] |y.org | Status|Signed Off |Failed QA CC| |[email protected] --- Comment #34 from Marcel de Rooy <[email protected]> --- WARN Koha/SearchMappingManager.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 11) WARN t/db_dependent/Koha/SearchEngine/ElasticSearch.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 76) +@THROWS die when parameters are not properly given. Should throw a Koha::Exception::BadParameter, + but pushing all those Exceptions to the community version would take ages. Hmm. Just adding that exception does not take ages. One die ? diff --git a/t/db_dependent/Koha/SearchEngine/ElasticSearch.t b/t/db_dependent/Koha/SearchEngine/ElasticSearch.t new file mode 100644 OK Fixed later +# Copyright 2015 Catalyst IT Fix? +use Modern::Perl qw(2014); Not what we do elsewhere? + $rv = Koha::SearchMappingManager::flush(); No transactions, no rollbacks ? OK Added later. General remark / question Given this comment: "Currently there is a lot of DBIC-magic everywhere where search mappings (search_fields, search_marc_to_field, search_marc_map -tables) are CRUD:ed. Encapsulate this hard-to-read DBIC-magic into a Manager class which promotes code-reusability and thus, simpler test case writing." Koha/SearchEngine/Elasticsearch.pm | 27 +--- Koha/SearchMappingManager.pm | 151 ++++++++++++++++++ .../Koha/SearchEngine/ElasticSearch.t | 127 +++++++++++++++ 3 files changed, 280 insertions(+), 25 deletions(-) I am not seeing large number of replaces to start using this new class? So could you explain the benefit of adding those 250 lines please? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
