http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] | |m QA Contact| |[email protected] | |m --- Comment #4 from Jonathan Druart <[email protected]> --- QA comments: The patch is clean and works well. But I have some remarks: - template_name => "members/purchase-suggestions.tmpl" could be .tt - in suggestion.pl, %hashlists is passed twice. - in suggestion.pl, $redirect could be eq to "purcharse-suggestion" with a new param borrowernumber=[%borrowernumber%] in order to open the possibility for an other script to use this redirection. - in purchase-suggestion.tt, some includes are useless: calendar.inc, tablesorter.js - The new tab is sometimes displayed on 2 lines and sometimes on 1 lines depending on which tab is enabled. I don't know how to fix that... - on the way, could you fix 4 withespaces: * suggestion/suggestion.pl FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (77) The patch introduces a forbidden pattern: withespace character (138) * koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (71) The patch introduces a forbidden pattern: withespace character (62) Marked as Failed QA -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
