http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9388
Owen Leonard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <[email protected]> --- This is not valid XHTML: <p class="problem"><h5>The item was returned</h5></p> It also perpetuates a class that we need to get rid of (not that one would know by looking at the code). The "problem" class is obsolete. This is a message rather than a warning, so it belongs in a different kind of dialog: <div class="dialog message"> <h5>Item successfully checked in</h5> </div> The above markup is valid, uses the proper message box style, and uses the correct phrase "checked in" which is default in the main "en" translation. I would like to see some references posted on this bug about the best way to offer text to screen readers which is hidden for sighted users. I think current Koha users are accustomed to the idea that "no news is good news" when checking out. Adding a message for those users disrupts their work flow by requiring that they distinguish between messages with actionable information and messages without. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
