http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9389
Owen Leonard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Owen Leonard <[email protected]> --- This change doesn't really make sense. In the template we have a lot of possible errors. Here are a few: [% IF ( DEBARRED ) %] <li>Patron is restricted</li> [% END %] [% IF ( NO_MORE_RENEWALS ) %] <h5><li>No more renewals possible</li></h5> [% END %] [%IF ( AGE_RESTRICTION ) %] <li>Age restriction [% AGE_RESTRICTION %].</li> [% END %] [% IF ( EXPIRED ) %] <li>Patron's card is expired</li> [% END %] 1. <h5> inside an <li> is not valid XHTML. 2. It doesn't make sense to wrap only one of many possible error messages in <h5> It would make more sense, I think, to add a heading to the message box itself: <div id="circ_impossible" class="dialog alert"> <!-- RESULT OF ISSUING REQUEST --> <h5>Could not complete checkout</h5> ...and have the list of messages below. Would this fulfill the same requirements? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
