http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|Signed Off |Passed QA Patch complexity|--- |Large patch QA Contact|[email protected] |[email protected] --- Comment #26 from Paul Poulain <[email protected]> --- QA comment: * from comment 27 I understand that Koha Team Lyon 3 sign-off the patch, I add their signature * squashed the main patch and the follow-up * koha-qa.pl complain because of POD in CA/Members/Attributes.pm, but the problem was already here. I fixed it during QA * koha-qa.pl complain because of tabs in admin/categorie.pl, but they were already here before, not failing QA for that * koha-qa complain because of "my" variable $sth masks earlier declaration in same scope "my" variable $dbh masks earlier declaration in same scope in admin/categorie.pl, that's added byt this patch, I've fixed that too * checked that things worked, could not find anything wrong * If I had written it myself, I would have added a 'branch' column, with a '*' for default, and used the same rule as for circulation rules, but the way it's done is OK. It will just make caching harder to develop (but that's another topic) * in templates, I feel the span with explanations could be styled a little bit better, but won't fail QA for that, someone (Owen ?) will for sure improve the look if needed Passed QA ! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
