http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9103
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Katrin Fischer <[email protected]> --- Hi Fridolyn, I like the idea to have a new sub that returns the correct email for the borrower according to the AutoEmailPrimaryAddress system preference. What bugs me a bit about it is the name of the new sub "GetPrimaryEmailAddress". I am not sure if you are aware of it, but some time ago the email and phone number fields in the patron record got renamed. The first email field in the English templates is now named 'Primary email:' - That makes it a bit confusing. Could you maybe choose a better name? Extra bonus points if you include some unit tests. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
