https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058
--- Comment #29 from Joonas Kylmälä <[email protected]> --- (In reply to Jonathan Druart from comment #28) > 1361 sub ItemsAnyAvailableAndNotRestricted { > > 1373 # we can return (end the loop) when first one found: > 1374 return 1 > 1375 unless $i->itemlost > 1376 || $i->notforloan > 1377 || $i->withdrawn > 1378 || $i->onloan > > > 1296 sub IsAvailableForItemLevelRequest { > 1312 return 0 if > 1313 $notforloan_per_itemtype || > 1314 $item->itemlost || > 1315 $item->notforloan > 0 || > 1316 $item->withdrawn || > > The different between the 2 $item->notforloan tests are obvious here? It clear by reading the comments, in IsAvailableForItemLevelRequest it states "Checks whether a given item record is *available for an item-level hold* request." For the other one, ItemsAnyAvailableAndNotRestricted, the comment states "item available for loan/check out". To make the situation more clear the function splitting renaming is needed yes, but the comments explaining this are already there. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
