http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572
--- Comment #28 from Kyle M Hall <[email protected]> --- > 1) Can you please add the new permisson for all languages? English is ok - > easier to add a translation than figuring out a missing permission. Done > 2) Some of the perl files have strict, but not warnings, can you add use > Modern::Perl? Done > 3) The Templates don't follow the capitalization rules. Examples: > Start Date > End Date > You Are Not Enrolled In Any Clubs Or Services Fixed > 4) This will not work for other languages, as noted in some of the earlier > comments: > $sth = $dbh->prepare("SELECT * FROM clubsAndServicesArchetypes WHERE title > LIKE 'Bestsellers Club' "); Fixed > 5) If I read the code correctly, this is another translation problem, adding > a hardcoded note to the hold: > + my $notes = "Automatic Reserve for Bestsellers Club", > Fixed > 6) I wonder about the error messages - from reading the code I am not > totally sure but I think they are also not translatable. > + <div>Reason: <strong>[% failureMessage %]</strong></div> Fixed > 7) Could you add documenation to the database tables? I was wondering about > the line: > + `casaId` int(11) NOT NULL default '0' COMMENT 'foreign key to > clubsAndServicesArchetypes', - not sure if COMMENT is a mysqlism. > > We had some discussion about following the standard in one of the IRC > meetings and agreed on using -- comment in the end. But I don't remember > exactly why. Fixed > 8) Another translation issue is the preset data you add in > kohastructure.sql. Also adding data to the tables is normally done by > separate sql files, while kohastructure is only creating the table structure > without any data. > > +-- Preset data for ClubsAndServicesArchetypes > +-- > + > +INSERT INTO `clubsAndServicesArchetypes`... Fixed > 9) There is a conflict marker in updatedatabase.pl and the version should be > set to be XXX. > +<<<<<<< HEAD > $DBversion = "3.09.00.005"; Removed > 10) There is some untranslatable JavaScript too. Example: > + alert("Title is a required field"); > + alert("Description is a required field"); Fixed > 11) There is a large block of code commented out. Maybe delete it, if it's > not needed? > +<!-- These messages are uneccessary because you can see if it was deleted > or created immediately... > Also some typos in there 'Archtype'. Removed > 12) It looks like the old calendar is being used? Not sure here. > + <img src="/intranet-tmpl/prog/en/lib/calendar/cal.gif" alt="Show > Calendar" border="0" id="CalendarStartDate" style="cursor: pointer;" /> Switched to the new calendar widget > 13) Ok, now I found something really big :( > > The doc states: > HTML::Template file mailinglist.tmpl > > Also: > +use HTML::Template::Pro; > > And then: > +++ b/misc/cronjobs/mailinglist/mailinglist.tmpl > > This needs to be redone to use TT. Done. Thanks for your good eyes! The original version of this feature was written in 2007 and Koha has moved quite a bit since then! I think this updated patch addresses all your concerns, and is definitely a big improvement. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
