http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382
Ian Walls <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |[email protected] --- Comment #10 from Ian Walls <[email protected]> --- Reimplements search as server-side, rather than client side with Javascript and JSON, so two large chunks of code are removed. Changes to GetPendingOrders function are clear and safe; new parameters are added at the end, so existing function calls do not need to be changed, and while $booksellerid is renamed to $supplierid internally, it's kept consistent within the function. POD for GetPendingOrders is updated, but the new parameters are not sufficiently described. Please provide more details on what these parameters actually do (a followup patch would be appropriate for this). Furthermore, unit tests should be expanded to cover the addition of the new filter options. A followup can be provided for this, as well. I'm still defrosting after a long absence, so all my tests are not yet working for other reasons, but to the best of my knowledge, this patch is safe and can pass QA. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
