http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Paul Poulain <[email protected]> --- QA comments: 1- Your patch contains: +sub _flush_preferences { + %sysprefs = (); +} Look here =head2 clear_syspref_cache C4::Context->clear_syspref_cache(); cleans the internal cache of sysprefs. Please call this method if you update the systempreferences table. Otherwise, your new changes will not be seen by this process. =cut sub clear_syspref_cache { %sysprefs = (); } => _flush_preferences is a duplicate ;-) Please provide another follow-up, switch back to signed-off & I'll pass QA, I don't see any other problem (about C4/HoldQueue.pm, even if we've now defined a structure, I agree it's a little bit early to ask for rewriting) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
