https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22688
Tomás Cohen Arazi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Tomás Cohen Arazi <[email protected]> --- Kyle, it seems to me that the test case you picked is the one that doesn't test pickup limitations (compared to all()). I think we should test: - Passing a selected => branchcode, then if selected => 1 is added to the hashref - Using mock_userenv({ branchcode => $library->branchcode }) to test the case in which C4::Context->userenv is used to pick the 'selected' library. I confess I spend a good amount of time today trying to implement a fully mocked test, only to learn that there's a problem with the 'selected' param because it would be passed all the way down to Koha::Libraries->search... This got into a rabbit hole (writing this tests). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
