https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547
--- Comment #22 from Marcel de Rooy <[email protected]> --- I was looking at 4319 that also proposes changes for this sub in Reserves, and somehow came here. The changes here seem too selective to me. Why are you looking at $branchitemrule->{holdallowed} == 1 only? Why do you not check the 0 value (no holds allowed) ? And why do you add this test only for If all unavailable? Should it not be tested globally, over the different values of On shelf holds allowed? Does not look good to me. Do I overlook something ? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
