http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7641
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |[email protected] --- Comment #6 from Paul Poulain <[email protected]> --- tests comments: * I tested many cases, could not find any problem * a possible enhancement could be for a patron to suspend holds one by one from the opac-user page. The common use-case is a patron that is unavailable for a long trip, another is "i placed a hold on volume 1 and 2, but want to suspend volume 2 until I have volume 1 in my hands". but that could be a future ENH QA comments: * There are 2 unconditional warnings in the logs: [Thu Mar 29 14:46:24 2012] [error] [client 127.0.0.1] [Thu Mar 29 14:46:24 2012] opac-modrequest-suspend.pl: C4::Reserves::SuspendAll( borrowernumber => 7852, biblionumber => , suspend_until => , suspend => 0 ) at /home/paul/koha.dev/koha-community/C4/Reserves.pm line 1562., referer: http://lecannet/cgi-bin/koha/opac-user.pl I've removed them in a follow-up * not worth failing QA because the rule is still at early stage, but a follow-up is requested for : + my $query = "UPDATE reserves SET suspend = 0, suspend_until = NULL WHERE DATE( suspend_until ) < DATE( CURDATE() )"; CURDATE is a mysqlism (see http://wiki.koha-community.org/wiki/PostgreSQL => CAST(now as date) * MARC BALMER (our mysqlism specialist :-) ) putting you in the loop: this patch contains + "UPDATE reserves SET suspend = NOT suspend, + suspend_until = CASE WHEN suspend = 0 THEN NULL ELSE suspend_until END => is it a mysqlism or no ? If yes, add it to your wiki page * prove translatable_templates and valid_templates are OK * misc/cronjobs/holds/auto_unsuspend_holds.pl had use strict/use warning commented, I've uncommented them in a follow-up, works fine * opac/opac-modrequest-suspend.pl and reserve/modrequest_suspendall.pl passes perlcritic * the + <td>[% IF ( reservloo.suspend ) %]Suspended [% IF ( reservloo.suspend_until ) %] until [% reservloo.suspend_until %][% END %][% END %]</td> should use kohaDates, not + $getreserv{suspend_until} = C4::Dates->new( $num_res->{'suspend_until'}, "iso")->output("syspref");; I'll pass QA & push because everything is OK except thig kohaDates display, but please provide a follow-up ASAP -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
