http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P3 Status|Signed Off |Passed QA CC| |[email protected] Hardware|PC |All Version|rel_3_4 |master QA Contact|[email protected] |[email protected] |ity.org | --- Comment #39 from M. de Rooy <[email protected]> --- Like this patch. Just have the impression that we once had this already? Anyhow, looks good. Two minor remarks: Error checking: What happens when GetURI returns undef on a URL? Could you fall back to default or no xslt view? Now you have a perl error: Empty String at /usr/share/koha/testclone/C4/XSLT.pm line 208 This needs a followup. You test Biblibre by: SELECT 1 FROM systempreferences WHERE variable="IntranetXSLTDetailsDisplay" Just theoretically, but someone else using this local pref could run into problems.. No blocker. Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
