https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021
--- Comment #33 from Jonathan Druart <[email protected]> --- (In reply to Marcel de Rooy from comment #30) > When you remove a sub from a module without full coverage, this is the > result. Something for QA tools ? Yes, could be improved. POD failures must be considered as warnings. (In reply to Marcel de Rooy from comment #31) > (In reply to Jonathan Druart from comment #8) > > It appears that has never worked. > > Could someone confirm? > > Did you have any response whatsoever ? I think we discussed it on IRC, but I do not find the logs. (In reply to Marcel de Rooy from comment #32) > QA Comment: > > GetOverduesForBranch > Please add a test. You make some fundamental changes here. Fundamental? I do not understand what you want me to test. > koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt > - <input type="hidden" name="totals[% line.accountlines_id %]" value="[% > line.totals %]" /> > Not sure. Why do yo remove this line ? Yes it could have been done somewhere else, it's not directly related to these changes. There is no "totals*" variables retrieved from the pl script. > New code: > + my $accounts = Koha::Account::Lines->search({ borrowernumber => > $borrowernumber, }, { order_by => ['accounttype'] }); > + my @accounts; > + while ( my $account = $accounts->next ) { > This does not look very nice. Can we get more confusion on $account, > @accounts or $accounts ? > Renaming @accounts here might be the least we can do? > No blocker on itself. Will fix. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
