http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420
Ian Walls <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Ian Walls <[email protected]> --- First patch renames 'MaxFine' to 'MAXFINE' in sysprefs.sql, which will cause breakage for new installations. The usage of 900 as an 'arbitrary value' for determining whether or not to port over the values from sysprefs to circ matrix is... unclear. Marking Failed QA. I'm concerned about this patch changing too much out from under the library. The meaning of MaxFine will change, and while this will port over *most* values of MaxFine into the circ matrix, this may still cause some confusion for folks who always thought that MaxFine was the total maximum for fines. Don't get me wrong, I'm behind separating this logic so folks can have both an item-specific max and a global max, but we need to make it VERY CLEAR on upgrade that this has changed. Perhaps that's more the job of the documenters and trainers than the coders, but I wanted to raise the point. I'm in favour making updatedatabase patches easier to merge, but I think the XXX markers are not the right way to go about it. What about just adding more whitespace between DB update lines? If that distance is greater than 3, Git won't grumble about a conflict, and so long as the spacing is less than 3 between the last DB update and the DropAllForeignKeys call, then the new update will be properly placed even if other updates have slipped in after it. An aside: this patch touches two very shaky areas of the codebase, Accounts and Circ Rules. These areas are already very prone to bugs, and need to be re-examined and probably rewritten. However, I don't think it's practical for me hold this up waiting on these large fixes. Get the MAXFINE issue solved, and make some attempt at forcing users to notice the change in behaviour, and we'll get a Passed QA. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
