http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7284
Ian Walls <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #27 from Ian Walls <[email protected]> 2012-03-01 19:27:09 UTC --- Argh, slipped and clicked save. Subroutine parameters: $marc_handler->valid_bib_heading_tag() is changed to take frameworkcode as a second param, but it's not used. In C4::Heading->new_from_bib_field, the framework is passed in and then on to valid_bib_heading_tag(), but not by C4/Linker/Default.pm. So, if the code is eventually updated to make use of the frameworkcode in valid_bib_heading_tag, and the "Default Linker" is used, there could be an error with an undefined value. Best to explicitly set $frameworkcode = shift || '' in valid_bib_heading_tag(), to future-proof this a bit. Untranslatable Strings: There are untranslatable strings in C4/Biblio.pm when creating the 'created by Koha' citation. The fields chosen aren't adjustable, either, but the having "Machine generated authority record." and "Work Cat." in the authority records automatically is less than optimal in any non-English environment. No other coding issues found through Perl analysis. All in all, I'm quite pleased with this patch and the new, well-documented functionality it includes. I'd recommend taking a look at these noted issues in a followup patch, but as they're not deal-breakers, I'm going to mark this as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
