http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929
--- Comment #27 from Paul Poulain <[email protected]> 2012-01-13 16:50:10 UTC --- QA comment: I was about to push this nice feature, but there is SQL in the .pl, and that's something we don't want. For example, in ordered.pl : +SELECT + aqorders.basketno, aqorders.ordernumber, + quantity-quantityreceived AS tleft, + ecost, budgetdate, + aqbasket.booksellerid, + itype, + title +FROM (aqorders, aqbasket) +LEFT JOIN biblio ON + biblio.biblionumber=aqorders.biblionumber +LEFT JOIN aqorders_items ON + aqorders.ordernumber=aqorders_items.ordernumber +LEFT JOIN items ON + items.itemnumber=aqorders_items.itemnumber +WHERE + aqorders.basketno=aqbasket.basketno AND + budget_id=? AND + (datecancellationprinted IS NULL OR + datecancellationprinted='0000-00-00') AND + (quantity > quantityreceived OR quantityreceived IS NULL) I also noticed that the POD is wrong: +=head1 NAME + +committed.pl I discussed of point #1 with kf on the channel, and she pointed this commit reinstate a script that was here, with SQL inside. So I won't mark failed QA, will add a follow-up for the small committed.pl mistake in the POD. BUT i'd like to have a follow-up to fix this SQL that should really not be here. patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
