http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488

Paul Poulain <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
       Patch Status|Signed Off                  |Failed QA

--- Comment #26 from Paul Poulain <[email protected]> 2012-01-03 
21:42:27 UTC ---
QA comment:
 1 this patch adds a lot of reindentation, he's quite hard to read. But those
indentations are needed, so it's OK
 2 prove t/00-perlcritic.t is OK
 3 prove xt/author/valid-templates.t is OK
 4 the patch works if XSLT is ON. With XSLT OFF there is no difference before
and after applying the patch.
 5 about the removed numbering, which one is it. On my setup & test I still see
a numbering after each item, for example:
Availability: Copies available for loan: Médiathèque Cannet des Maures[800]
(43). Copies available for reference: Médiathèque Cannet des Maures[800] (1).
Checked out (2). 

Marking failed QA until I've some feedback for points 4 and 5

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to