http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Patch Status|Signed Off |Failed QA --- Comment #7 from Paul Poulain <[email protected]> 2011-12-14 17:17:05 UTC --- QA comment : Adrien, I think you've found a problem with this syspref ! But if I push your patch like this, then anyone with an https opac won't have rss enabled. So, please resubmit a patch with this code removed. you can also replace the + if ( $OPACRssURL !~ m/^http:\/\// ) { $OPACRssURL = "http://"; . $OPACRssURL } by something like + if ( $OPACRssURL !~ m/^http(s?):\/\// ) { $OPACRssURL = "http://"; . $OPACRssURL } I think (untested regexp!) marking failed QA, when new patch submitted, switch back to signed-off, the change is small -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
