http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7110
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |master Patch Status|Signed Off |Failed QA --- Comment #3 from M. de Rooy <[email protected]> 2011-11-24 13:01:24 UTC --- QA Comment: warning: 2 lines add whitespace errors. The two tests in opac-user and the template are not completely in harmony. Note that you only set renewal_blocked_fines if fines higher than threshold and opac renewal is allowed, but the template wants to warn also if there are higher fines. Further take into account that flagged could be 1 for another reason and that could result in a wrong message from the else part in the template. So, I think that the test in opac-user should not include OpacRenewal. Leave it as it was. And rewrite the checks in the template: if Renewal allowed and higher fines then message 1 elseif Higher fines then message 2 else nothing. Hopefully, I was clear enough ;) Thanks your further attention to these details. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
