http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836
--- Comment #16 from Owen Leonard <[email protected]> 2011-11-23 16:24:49 UTC --- > - Some image files in CSS are not in my local repository and don't come with > the patch (img/arrow-*.png). This causes "full_numbers" pagination to have > large empty space before or after labels ("First", "Back", etc.) Confirmed, sorry about that. > - The initial goal of this bug is to provide only the javascript library and > other stuff (css, images, ...) but no tables using it, so patches contain only > new files and could be easy to apply. Maybe you can separate your patch in two > parts (and remove the modif on serials-home.tt so we can apply both patches > from bug 6836 without applying patch from bug 6838) Sure, I just wanted an easily-testable patch so I could get others' input on the changes I was playing around with. > - If I don't use the 'sDom' property, the display is completely broken, so > it has to be fixed I don't understand. > - I prefer images from datatables.net rather than the ones used with > tablesorter, but it's just a matter of taste Let's get some more opinions. > (In reply to comment #12) > > I'm a little concerned about the significant increase in the plugin size: > > Good point, I haven't noticed that. But it seems that DataTables is still > faster than tablesorter. For example, on authorised values admin page, with > large list of values (~1000), tablesorter sometimes caused firefox freezes and > DataTables don't (but maybe it's just a firefox issue, I don't know) I'm glad you've tested with larger data sets. Performance has certainly been an issue with tablesorter, so it would be nice for that factor to be another plus for DataTables. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
