http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4518
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Patch Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy <[email protected]> 2011-11-14 11:26:44 UTC --- Two small QA remarks. move_marc_to_authheader.pl This pertains to UNIMARC only. Is not clear from name of script or initial comments. Compare with warning in misc/migration_tools/upgradeitems.pl. upgradeitems.pl The way the code uses $rqitemnumber is somewhat questionable. Apparently, you want to check the existence of itemnumber from 995 in items table. In the for loop at the end only the last item number is passed to ModItemFromMarc. I assume that there should always only be one subfield 9. Code will work therefore, but could be improved. I set the status to Passed QA and let Paul decide if he wants to push or change status to Failed QA and work first on it. It should not stay on hold in the Signed Off queue. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
