http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #74 from Katrin Fischer <[email protected]> --- Hi Jonathan, some notes about from testing: 1) (trivial) The QA script complained about a char character and about a missing blank line before a =cut in Serials.pm - I am attaching a small patch to fix those. If you think they are good, feel free to squash them into the follow up. 2) (normal) Your patch removes the ISSN column on the claims.tt page. I have confirmed the ISSN is displayed before your patch - so I think we should keep it. 3) (question/normal) Without the patch, a vendor won't show up in the list of vendors on the claims page, if the number of late issues is 0. Now the vendor is shown in the list with a (0) behind the name. I wonder if it would be more ergonomic to not list them or if libraries want to have those listed as well. 4) (note) When you select no issue in the list, a message is shown: Please select at least one item. I think for translation it would be a bit nicer to make it more explicit: Please select at least one issue. 5) (major) The tests are failing on my database :( t/db_dependent/Serials/Claims.t ......... 2/13 # Failed test 'There is no late issues yet' # at t/db_dependent/Serials/Claims.t line 78. # got: '1' # expected: '0' # Failed test 'There is still no late issues yet' # at t/db_dependent/Serials/Claims.t line 89. # got: '1' # expected: '0' # Failed test '2 suppliers should have issues in late' # at t/db_dependent/Serials/Claims.t line 120. # got: '3' # expected: '2' # Looks like you failed 3 tests of 13. t/db_dependent/Serials/Claims.t ......... Dubious, test returned 3 (wstat 768, 0x300) Failed 3/13 subtests 6) (normal) My staff user has a primary email defined, but I still get the message: No email is configured for your user. The vendor has an email defined as well and all checkboxes are checked. I double checked - I am not sure what's going wrong here. Failing for 2), 5) and 6). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
