http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6328
--- Comment #34 from Paul Poulain <[email protected]> 2011-10-11 16:28:50 UTC --- Created attachment 5841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5841 follow-up to deal with QA comments This patch fixes Ian's comments on QA : Doesn't update all instances of $borrower->{'debarred'}; there are usages on the following files that are not updated to reflect the change data type for 'debarred': opac/opac-reserve.pl => OK, fixed opac/opac-user.pl => I don't see where there is a problem, the field is properly managed. Tested by debarring & undebarring a patron. members/setdebar.pl => I don't see where there is a problem, seems to work. Tested by debarring a patron. misc/cronjobs/notifyMailsOp.pl => this script is deprecated (as written in the doc : http://manual.koha-community.org/3.4/en/cronjobsch.html), it should be removed I think (that should be in another patch/bug) C4/ILSDI/Utility.pm => OK, fixed C4::Members::patronflags() is not touched, so the DBARRED flag in GetMemberDetails is never set; => OK, fixed, and tested by debarring/undebarring a patron. I've discovered that the "patron debarred" message was displayed twice, i've fixed this too. There is some documentation on C4/Auth_with_ldap.pm that needs updating as well. => fixed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
