http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6280
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4438|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <[email protected]> 2011-08-10 13:00:53 UTC --- Created attachment 4935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4935 proposed patch (passed QA) QA comment * works as announced, usefull patch, logs will thank you forever ;-) * Just a minor comment/suggestion. You write: +if ( @borrowernumbers ) { + $relissue = GetPendingIssues(@borrowernumbers); +} It's correct although it's more perlish to have : $relissue = GetPendingIssues(@borrowernumbers) if @borrowernumbers; I agree with the change - ($_->{date_due} lt $today) and $_->{overdue} = 1; to + if ($_->{date_due} and $_->{date_due} lt $today) { + $_->{overdue} = 1; + } (we must be Perlish, but sometimes that result in really cryptic things...) passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
