http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4959
--- Comment #20 from M. de Rooy <[email protected]> 2011-08-03 11:03:13 UTC --- (In reply to comment #19) > QA comment > > Reading the patch and thinking of ergonomy rules we try to follow in Koha, I > think this patch addresses a problem, but in a wrong way. > > Ergonomic rule = don't ask for confirmation if you can cancel the operation. > For example, when you add something, you can delete it after, so don't ask "do > you want to add this". Usually, confirmations are added only for deletions. > > So I would say : > * remove the confirmation for reopening the basket, it's useless (you can > always close it again) > * For the close with creating a basket group or no form, it's still needed (as > it's not only a confirmation), so i'm OK with the > - <label for="createbasketgroup">create a purchase order now?</label> > + <label for="createbasketgroup">Attach this basket to a new basket group with > the same name</label> > > benefit = no syspref added. (I'm strongly against multiplicating sysprefs, we > already have too many !) > > IAN = I propose QA failed (but won't set it) This patch just came forth out of Koha not being so ergonomic in this area! I can understand that you do not want unnecessary sysprefs. If it now fails QA after being rebased a number of times and signoff, I suggest to close the patch. Too bad for the time being spent on it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
