https://dev-docs.kicad.org/en/rules-guidelines/code-style/ has been updated to clarify this point.
-Jon On Mon, Jul 5, 2021 at 12:32 PM Jon Evans <j...@craftyjon.com> wrote: > Lines which only contain braces do count as a blank line in this context. > We should clarify this in the style guide. > > Best, > Jon > > On Mon, Jul 5, 2021 at 2:20 AM Markus Bonk <markus_b...@3dconnexion.com> > wrote: > >> Hi, >> >> >> >> In my opinion there may be issues with the examples in the KiCAD coding >> style doc relating to 4.2.3 Control Statements. >> >> 4.2.3 requires one blank line before and after the statement block. >> Example 4.7 & 4.8 (for example) has missing opening and closing blank lines >> for the while and if blocks. >> >> >> >> Do lines which only contain braces count as a blank line? >> >> >> >> The example for 10. Function CharAt also violates 4.2.3 >> >> >> >> Markus >> >> >> >> >> >> ------------------------------ >> >> *Markus Bonk* >> Senior Software Engineer >> >> Clarita-Bernhard-Str. 18 >> 81249 München >> Germany >> markus_b...@3dconnexion.com <%7BE-mail%7D> >> www.3dconnexion.com >> >> Geschäftsführer: Antonio Pascucci >> Sitz der Gesellschaft: München >> Registergericht: München HRB 99232 >> >> This email and any files transmitted with are from 3Dconnexion GmbH. The >> contents of this email and any attachments are confidential to the intended >> recipient. They may not be disclosed to or used by or copied in any way by >> anyone other than the intended recipient. If this email is received in >> error, please contact 3Dconnexion GmbH by calling +49 89 8974542-0 and then >> delete it. Please note that neither 3Dconnexion GmbH nor the sender accepts >> any responsibility for viruses and it is your responsibility to scan or >> otherwise check this email and any attachments. Any opinion expressed in >> this email are those of the individual and not necessarily those of >> 3Dconnexion GmbH. >> 3Dconnexion GmbH processes and stores for commercial purposes your >> personal data, collected upon your consent, in accordance with its privacy >> policy available at https://www.3dconnexion.eu/privacy.html, which has >> been drafted in accordance with Regulation (EU) no. 679/2016 and all >> applicable local data protection laws and regulations of the countries >> where the company operates. To revoke your consent or exercise all your >> rights with regards to personal data, please contact us at >> priv...@3dconnexion.com. >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
