Do we still need spice as a build option? It would be nice to bring down the number of permutations out there and the SPICE simulator is really a first-class KiCad citizen nowadays.
-S On Thu, Mar 18, 2021 at 4:04 PM Jon Evans <j...@craftyjon.com> wrote: > Saving in the project file is fine, I just mean if you split out > NGSPICE_SIMULATOR_SETTINGS to a different file (not sim/ngspice.h) with no > dependencies on ngspice itself, the settings class can be built without > ngspice. > > On Thu, Mar 18, 2021 at 6:57 PM Wayne Stambaugh <stambau...@gmail.com> > wrote: > >> I thought about that but in what context does a simulation make sense >> out side of a schematic or a netlist generated from a schematic? I >> saved the ngspice simulator settings in the project file because that is >> the proper scope of the setting. I really don't see a more logical >> place to save the setting. I suppose I could split out the simulator >> settings code but it would be awkward at best. >> >> On 3/18/21 6:42 PM, Jon Evans wrote: >> > Wayne, I haven't checked this code carefully but I'd recommend building >> > the settings always, and moving the #ifdef to a different level (i.e. >> > make the settings not depend on ngspice) >> > >> > That way if the same settings files are shared between a build with >> > ngspice and a build without, they won't get thrown away. >> > >> > On Thu, Mar 18, 2021 at 6:37 PM Wayne Stambaugh <stambau...@gmail.com >> > <mailto:stambau...@gmail.com>> wrote: >> > >> > My bad. I forgot the simulator was a build option so I will have to >> > #ifdef the offending settings code. >> > >> > - Wayne >> > >> > On 3/18/21 6:02 PM, Eeli Kaikkonen wrote: >> > > I have disabled ngspice in cmake settings but in a recent commit >> by >> > > Wayne #include <sim/ngspice.h>, which in turn includes >> > > ngspice/sharedspice.h, was added to schematic.cpp which makes >> > > compilation fail apparently because I don't have ngspice at all. >> > > >> > > Eeli Kaikkonen >> > > >> > > _______________________________________________ >> > > Mailing list: https://launchpad.net/~kicad-developers >> > <https://launchpad.net/~kicad-developers> >> > > Post to : kicad-developers@lists.launchpad.net >> > <mailto:kicad-developers@lists.launchpad.net> >> > > Unsubscribe : https://launchpad.net/~kicad-developers >> > <https://launchpad.net/~kicad-developers> >> > > More help : https://help.launchpad.net/ListHelp >> > <https://help.launchpad.net/ListHelp> >> > > >> > >> > _______________________________________________ >> > Mailing list: https://launchpad.net/~kicad-developers >> > <https://launchpad.net/~kicad-developers> >> > Post to : kicad-developers@lists.launchpad.net >> > <mailto:kicad-developers@lists.launchpad.net> >> > Unsubscribe : https://launchpad.net/~kicad-developers >> > <https://launchpad.net/~kicad-developers> >> > More help : https://help.launchpad.net/ListHelp >> > <https://help.launchpad.net/ListHelp> >> > >> > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > -- [image: KiCad Services Corporation Logo] Seth Hillbrand *Lead Developer* +1-530-302-5483 Long Beach, CA www.kipro-pcb.com i...@kipro-pcb.com
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
