Hi Nick, It seems that Seth Hillbrand already commited a fix to it.
Augusto. Nick Østergaard writes: > Please submit it directly on gitlab as a merge request. > > https://gitlab.com/kicad/code/kicad > > fre. 21. aug. 2020 14.17 skrev Augusto Fraga Giachero <augustof...@gmail.com >>: > >> Hi, >> >> I've experienced crashes in pcbnew when creating a cooper fill zone when >> no board edges has been defined. Tuns out that BuildBoardPolygonOutlines >> is called with aErrorText set to nullptr an it tries to deference it to >> write an error message when no board edges has been found. >> >> The attached patch checks aErrorText and only deference it if it is not >> nullptr. >> >> Upon further investigation I discovered that the overloaded method >> BOARD::GetBoardPolygonOutlines is called from ZONE_FILLER::Fill with its >> default values of aErrorText and aErrorLocation (both nullptr). Wouldn't >> be better to supply a valid pointer to aErrorText to inform the user >> about the error / warning in this case? >> >> Thanks, >> Augusto. >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
